feat: Support root nameserver and additional record types

[maikelpoot]

This PR will add support for all additional record types transip supports at the moment:

• Root NS
• ALIAS
• DS
• NAPTR
• TLSA

[maikelpoot]

Ideally the caveats would be catched/fixed in the planning/validating phase but couldn't find any documentation or examples how to.

[ross]

Ideally the caveats would be catched/fixed in the planning/validating phase but couldn't find any documentation or examples how to.

_process_desired_zone is the place to do that sort of checking, it's requirements are in the docstring:

https://github.com/octodns/octodns/blob/9f73103300927733c691bf765866ec5c6f2e5784/octodns/provider/base.py#L35-L52

You can search the org for what various providers are doing/checking in that function:

https://github.com/search?q=org%3Aoctodns%20_process_desired_zone&type=code

The azure provider looks like it has something that's fairly close to the root caveats:

https://github.com/octodns/octodns-azure/blob/374f95986d884dc603ba0dbe55226c2b6595cf6d/octodns_azure/__init__.py#L1343

As for the TTL bit I'm not sure what makes sense. It could always warn if there's a non-matching value and just go ahead with that value or it could do the standard supports_warn_or_except behavior.

[maikelpoot]

_process_desired_zone is indeed what i was searching for.
Refactored the code to validate the root nameserver in _process_desired_zone

[maikelpoot]

Changed it to draft for now, The opt-in for NS is a pain in .... when dealing with larger sets of domains in the config.

Trying to refactor to something like the googlecloud provider:

WARNING GoogleCloudProvider[google_public] root NS record supported, but no record is configured for example.com.
 INFO  GoogleCloudProvider[google_public] root NS record in existing, but not supported or not configured; ignoring it

[ross]

Trying to refactor to something like the googlecloud provider:

IIRC that's just using the default/built-in root handling of the base class.

https://github.com/octodns/octodns/blob/9f73103300927733c691bf765866ec5c6f2e5784/octodns/provider/base.py#L152-L166

[maikelpoot]

@ross Thanks for the info.
Removed the opt-in code, updated all the tests and tested the code with some real-world config.
So i think this one is ready for review.

[ross]

Overall looks good. Few minor things inline and it should be ready to 🚢

Thanks.

[maikelpoot]

Thought i tried that before without success, but maybe did something else wrong then.

Removed the usage of .data for both the record= and the if change.data['name'] == '' and change.data['record_type'] == 'NS': using the record from "new" to check.

[ross]

Thanks.

[maikelpoot]

@ross Do you have an idea when the next release of the provider will be (and/or when it will be included within the docker containers, github action etc etc)

[ross]

/cc #42