Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testcase to test deletion to fix #44 #45

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

maikelpoot
Copy link
Contributor

This PR will add a test case that touches deletions within apply.

Tested this also with the "old" code and it did catch the runtime error:

% ./script/test
...
        for change in changes:
            record = change.new

>           if record.name == '' and record._type == 'NS':
E           AttributeError: 'NoneType' object has no attribute 'name'

octodns_transip/__init__.py:259: AttributeError
...
=== short test summary info ===
FAILED tests/test_provider_octodns_transip.py::TestTransipProvider::test_apply_deletions - AttributeError: 'NoneType' object has no attribute 'name'
=== 1 failed, 21 passed in 0.35s

@ross ross merged commit 58ae67d into octodns:main Nov 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants