Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: package is now ESM #512

Merged
merged 10 commits into from
Apr 30, 2024
Merged

feat: package is now ESM #512

merged 10 commits into from
Apr 30, 2024

Conversation

wolfy1339
Copy link
Member

BREAKING CHANGE: package is now ESM

@wolfy1339
feat: package is now ESM
f970e0d 
BREAKING CHANGE: package is now ESM
@wolfy1339 wolfy1339 added Type: Feature New feature or request Type: Breaking change Used to note any change that requires a major version bump labels Feb 25, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339

This comment has been minimized.

Sign in to view
@wolfy1339
fix: bump deps
a2f35e9
@wolfy1339
fix(pkg): add main entry point
09e0241 
Some tools don't play well with only having the `exports` field present.

See octokit/core.js#662
@harryzcy
Copy link

Is there an ETA on this?

@wolfy1339
Copy link
Member Author

Currently blocked by octokit/auth-app.js#580

As for an ETA, there isn't one. I'm just a volunteer open source contributor

@wolfy1339
Copy link
Member Author

This is odd... The tests are passing here, but not in octokit/auth-app.js#580

@wolfy1339 wolfy1339 marked this pull request as ready for review April 30, 2024 17:16
@wolfy1339 wolfy1339 merged commit ea347ff into main Apr 30, 2024
7 checks passed
@wolfy1339 wolfy1339 deleted the beta branch April 30, 2024 17:34
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 15.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ekmixon ekmixon mentioned this pull request May 21, 2024
Open
@ekmixon ekmixon mentioned this pull request Jun 27, 2024
Open
This was referenced Sep 9, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfy1339 @harryzcy @gr2m