-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pkg): add main entry point #662
Conversation
…rror `Unable to resolve path to module '@octokit/core'`
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
I wonder why that is. Shouldn't the |
I thought so too, but |
Can you add the |
You mean the |
Sorry, I meant |
Sure, I just committed the update. |
🎉 This PR is included in version 6.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks @wolfy1339 |
Some tools don't play well with only having the `exports` field present. See octokit/core.js#662
Some tools don't play well with only having the `exports` field present. See octokit/core.js#662
Some tools don't play well with only having the `exports` field present. See octokit/core.js#662
Some tools don't play well with only having the `exports` field present. See octokit/core.js#662
Some tools don't play well with only having the `exports` field present. See octokit/core.js#662
Some tools don't play well with only having the `exports` field present. See octokit/core.js#662
Before the change?
Now that the package is ESM,
eslint
may return the following errors:After the change?
eslint should no longer report the errors
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!