-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pkg): add default
fallback and types
export
#673
Conversation
Many people are importing from `dist-types/types.d.ts`, and the switch to ESM prevents them from using any of the types defined in that file.
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
I have tested this locally with eslint, and the problem seems to be fixed |
🎉 This PR is included in version 6.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi,
I can open PRs for all of these, but I don't know if this isn't something you'd rather solve for the whole org... |
Yes, that is expected, as they haven't received the same update yet. Yes, I would love PRs! |
Sorry, you got to it faster than I could :) Thanks! |
No worries 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[SPAM]
Resolves #667
Resolves #665
Partly reverts #662
Before the change?
jest
,ts-node
,tsx
)After the change?
dist-types/types.d.ts
file in the packagePull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!