Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): avoid the void #356

Merged
merged 2 commits into from
Jun 13, 2021
Merged

fix(typescript): avoid the void #356

merged 2 commits into from
Jun 13, 2021

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Jun 13, 2021

prevents the octokit instance from becoming an intersection with void, see octokit/octokit.js#2115

@gr2m gr2m added the typescript Relevant to TypeScript users only label Jun 13, 2021
@gr2m gr2m added the Type: Bug Something isn't working as documented label Jun 13, 2021
@gr2m gr2m mentioned this pull request Jun 13, 2021
Closed
@gr2m gr2m force-pushed the avoid-the-void branch from 5a6144a to e89c39c Compare June 13, 2021 23:46
@gr2m gr2m merged commit 971ac2a into master Jun 13, 2021
@gr2m gr2m deleted the avoid-the-void branch June 13, 2021 23:49
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@IbrahimAli12
Copy link

We

1 similar comment
@IbrahimAli12
Copy link

We

@octokit octokit locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zyckzyck Zyckzyck Zyckzyck approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented typescript Relevant to TypeScript users only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gr2m @IbrahimAli12 @Zyckzyck