-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove previews #538
base: main
Are you sure you want to change the base?
Conversation
f31f308
to
fa850ab
Compare
Previews still exist for the GraphQL endpoint, this as-is won't work |
What do you suggest we should do @wolfy1339 ? |
For the types, we can probably do a ternary expression based on the endpoint, to only have previews for GraphQL as it is only one endpoint ( For the code itself a simple if statement can work How does that sound? |
Sounds good to me. |
* build(package): set minimal node version in engines field to v18 * build: update esbuild options to use Node 18 BREAKING CHANGE: Drop support for NodeJS v14, v16
fa2a665
to
ecce98e
Compare
Since the underlying packages have been updated to no longer support previews for the REST API, this shouldn't be a breaking change. I will come back to this once things calm down with the major version bumps |
if you could add a test to https://github.com/octokit/core.js/blob/main/test/graphql.test.ts with a preview that'd be 💯 |
Followup to octokit/endpoint.js#382 (comment)
See also octokit/endpoint.js#388 octokit/plugin-paginate-rest.js#486
Requires octokit/types.ts#491
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Feature
Type: Documentation
Type: Maintenance