Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updates CheckRun.id to the proper type #49

Merged
merged 1 commit into from
Aug 22, 2024
Merged

feat: Updates CheckRun.id to the proper type #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/GitHub/Models/CheckRun.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public class CheckRun : IAdditionalDataHolder, IParsable
public string HtmlUrl { get; set; }
#endif
/// <summary>The id of the check.</summary>
public int? Id { get; set; }
public long? Id { get; set; }
/// <summary>The name of the check.</summary>
#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP3_1_OR_GREATER
#nullable enable
Expand Down Expand Up @@ -152,7 +152,7 @@ public virtual IDictionary<string, Action<IParseNode>> GetFieldDeserializers()
{"external_id", n => { ExternalId = n.GetStringValue(); } },
{"head_sha", n => { HeadSha = n.GetStringValue(); } },
{"html_url", n => { HtmlUrl = n.GetStringValue(); } },
{"id", n => { Id = n.GetIntValue(); } },
{"id", n => { Id = n.GetLongValue(); } },
{"name", n => { Name = n.GetStringValue(); } },
{"node_id", n => { NodeId = n.GetStringValue(); } },
{"output", n => { Output = n.GetObjectValue<CheckRun_output>(CheckRun_output.CreateFromDiscriminatorValue); } },
Expand All @@ -178,7 +178,7 @@ public virtual void Serialize(ISerializationWriter writer)
writer.WriteStringValue("external_id", ExternalId);
writer.WriteStringValue("head_sha", HeadSha);
writer.WriteStringValue("html_url", HtmlUrl);
writer.WriteIntValue("id", Id);
writer.WriteLongValue("id", Id);
writer.WriteStringValue("name", Name);
writer.WriteStringValue("node_id", NodeId);
writer.WriteObjectValue<CheckRun_output>("output", Output);
Expand Down
2 changes: 0 additions & 2 deletions src/GitHub/Repos/Item/Item/Contents/Item/WithPathItemRequestBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ public async Task<WithPathGetResponse> GetAsync(Action<RequestConfiguration<With
/// <param name="cancellationToken">Cancellation token to use when cancelling requests</param>
/// <param name="requestConfiguration">Configuration for the request such as headers, query parameters, and middleware options.</param>
/// <exception cref="BasicError">When receiving a 404 status code</exception>
/// <exception cref="BasicError">When receiving a 409 status code</exception>
/// <exception cref="ValidationError">When receiving a 422 status code</exception>
#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP3_1_OR_GREATER
#nullable enable
Expand All @@ -113,7 +112,6 @@ public async Task<FileCommit> PutAsync(WithPathPutRequestBody body, Action<Reque
var errorMapping = new Dictionary<string, ParsableFactory<IParsable>>
{
{"404", BasicError.CreateFromDiscriminatorValue},
{"409", BasicError.CreateFromDiscriminatorValue},
{"422", ValidationError.CreateFromDiscriminatorValue},
};
return await RequestAdapter.SendAsync<FileCommit>(requestInfo, FileCommit.CreateFromDiscriminatorValue, errorMapping, cancellationToken).ConfigureAwait(false);
Expand Down
2 changes: 0 additions & 2 deletions src/GitHub/Repos/Item/Item/Git/Blobs/BlobsRequestBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ public BlobsRequestBuilder(string rawUrl, IRequestAdapter requestAdapter) : base
/// <exception cref="BasicError">When receiving a 403 status code</exception>
/// <exception cref="BasicError">When receiving a 404 status code</exception>
/// <exception cref="BasicError">When receiving a 409 status code</exception>
/// <exception cref="ValidationError">When receiving a 422 status code</exception>
#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP3_1_OR_GREATER
#nullable enable
public async Task<ShortBlob?> PostAsync(BlobsPostRequestBody body, Action<RequestConfiguration<DefaultQueryParameters>>? requestConfiguration = default, CancellationToken cancellationToken = default)
Expand All @@ -71,7 +70,6 @@ public async Task<ShortBlob> PostAsync(BlobsPostRequestBody body, Action<Request
{"403", BasicError.CreateFromDiscriminatorValue},
{"404", BasicError.CreateFromDiscriminatorValue},
{"409", BasicError.CreateFromDiscriminatorValue},
{"422", ValidationError.CreateFromDiscriminatorValue},
};
return await RequestAdapter.SendAsync<ShortBlob>(requestInfo, ShortBlob.CreateFromDiscriminatorValue, errorMapping, cancellationToken).ConfigureAwait(false);
}
Expand Down
2 changes: 1 addition & 1 deletion src/GitHub/kiota-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"descriptionHash": "86C5D11D01116E2C1F2A835544126745671AC771F3A1AF1A01B9054F627A35ECF647D8D0084D5A4ACA4E89A7FF6FCCC2AE8134A146CA201FFDBC25D2B925E708",
"descriptionHash": "6CA137E1F68B10CB479F25A8C8834292DE7E77CD31EED411A6F07ADC2F822AE77386DA8282A349AA08AA0C97D296A957F77EF5F0BD685754B62676BE2E75A07A",
"descriptionLocation": "../../../../../schemas/ghes-3.12.json",
"lockFileVersion": "1.0.0",
"kiotaVersion": "1.14.0",
Expand Down
Loading