-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ES Module #159
feat: ES Module #159
Conversation
@gr2m There is only one regular test failure left, due to The e2e tests don't currently work. They are complaining that |
Thanks @wolfy1339 I'll have a look |
I'd like to resolve octokit/fixtures#425 first |
From what I gather, I think moving to Jest is going to be a requirement here |
no problem from my side |
BREAKING CHANGE: Move to ESModules instead of CommonJS
There isn't any stable replacement for `require.resolve` yet
I use |
ugh now the build fails due to vercel/pkg#1254 |
we might need to add a pre-build step with esbuild as described here: At this point we could as well look into Deno instead which has the single-file binary compilation built in, what do you think? |
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: Move to ESModules instead of CommonJS