generalize this pattern for now

octokit · Feb 10, 2020 · d588812 · d588812
1 parent c238937
commit d588812
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/Octokit/Models/Request/SearchRepositoriesRequest.cs b/Octokit/Models/Request/SearchRepositoriesRequest.cs
@@ -341,7 +341,7 @@ public DateRange(DateTime from, DateTime to)
  /// </summary>
  public DateRange(DateTimeOffset from, DateTimeOffset to)
  {
- query = $"{from.ToString(DateTimePattern, CultureInfo.InvariantCulture)}..{to.ToString(DateTimePattern, CultureInfo.InvariantCulture)}";
+ query = EncodeOffset($"{from.ToString(DateTimePattern, CultureInfo.InvariantCulture)}..{to.ToString(DateTimePattern, CultureInfo.InvariantCulture)}");
  }
 
  /// <summary>
@@ -353,20 +353,25 @@ public DateRange(DateTimeOffset dateTime, SearchQualifierOperator op)
  switch (op)
  {
  case SearchQualifierOperator.GreaterThan:
- query = dateTime.ToString($">{DateTimePattern}", CultureInfo.InvariantCulture).Replace("+", "%2B");
+ query = EncodeOffset(dateTime.ToString($">{DateTimePattern}", CultureInfo.InvariantCulture));
  break;
  case SearchQualifierOperator.LessThan:
- query = dateTime.ToString($"<{DateTimePattern}", CultureInfo.InvariantCulture);
+ query = EncodeOffset(dateTime.ToString($"<{DateTimePattern}", CultureInfo.InvariantCulture));
  break;
  case SearchQualifierOperator.LessThanOrEqualTo:
- query = dateTime.ToString($"<={DateTimePattern}", CultureInfo.InvariantCulture);
+ query = EncodeOffset(dateTime.ToString($"<={DateTimePattern}", CultureInfo.InvariantCulture));
  break;
  case SearchQualifierOperator.GreaterThanOrEqualTo:
- query = dateTime.ToString($">={DateTimePattern}", CultureInfo.InvariantCulture);
+ query = EncodeOffset(dateTime.ToString($">={DateTimePattern}", CultureInfo.InvariantCulture));
  break;
  }
  }
 
+ private string EncodeOffset(string dateTimeOffset)
+ {
+ return dateTimeOffset.Replace("+", "%2B");
+ }
+
  internal string DebuggerDisplay
  {
  get { return string.Format(CultureInfo.InvariantCulture, "Query: {0}", query); }