Initialise collection when accessed

octokit · Jan 25, 2025 · fc283af · fc283af
1 parent 7fa5b0f
commit fc283af
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 59 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,4 +1,7 @@
 <Project>
+  <PropertyGroup>
+    <LangVersion>latest</LangVersion>
+  </PropertyGroup>
   <PropertyGroup Label="Strong name signing">
     <SignAssembly>true</SignAssembly>
     <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)\key.snk</AssemblyOriginatorKeyFile>

diff --git a/Octokit/Models/Request/IssueUpdate.cs b/Octokit/Models/Request/IssueUpdate.cs
@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Diagnostics;
 using System.Globalization;
 using Octokit.Internal;
@@ -12,6 +11,9 @@ namespace Octokit
     [DebuggerDisplay("{DebuggerDisplay,nq}")]
     public class IssueUpdate
     {
+        private ICollection<string> _labels;
+        private ICollection<string> _assignees;
+
         /// <summary>
         /// Title of the issue (required)
         /// </summary>
@@ -28,7 +30,7 @@ public class IssueUpdate
         /// <remarks>
         /// Only users with push access can set the multiple assignees for new issues.  The assignees are silently dropped otherwise.
         /// </remarks>
-        public ICollection<string> Assignees { get; private set; }
+        public ICollection<string> Assignees => _assignees ??= [];
 
         /// <summary>
         /// Milestone to associate this issue with.
@@ -46,7 +48,7 @@ public class IssueUpdate
         /// <remarks>
         /// Only users with push access can set labels for new issues. Labels are silently dropped otherwise.
         /// </remarks>
-        public ICollection<string> Labels { get; private set; }
+        public ICollection<string> Labels => _labels ??= [];
 
         /// <summary>
         /// Whether the issue is open or closed.
@@ -58,26 +60,14 @@ public class IssueUpdate
         /// </summary>
         public ItemStateReason? StateReason { get; set; }
 
-        internal string DebuggerDisplay
-        {
-            get
-            {
-                return string.Format(CultureInfo.InvariantCulture, "Title: {0}", Title);
-            }
-        }
+        internal string DebuggerDisplay => string.Format(CultureInfo.InvariantCulture, "Title: {0}", Title);
 
         /// <summary>
         /// Adds the specified assignees to the issue.
         /// </summary>
         /// <param name="name">The login of the assignee.</param>
         public void AddAssignee(string name)
         {
-            // lazily create the assignees array
-            if (Assignees == null)
-            {
-                Assignees = new List<string>();
-            }
-
             Assignees.Add(name);
         }
 
@@ -86,15 +76,7 @@ public void AddAssignee(string name)
         /// </summary>
         public void ClearAssignees()
         {
-            // lazily create the assignees array
-            if (Assignees == null)
-            {
-                Assignees = new List<string>();
-            }
-            else
-            {
-                Assignees.Clear();
-            }
+            Assignees.Clear();
         }
 
         /// <summary>
@@ -103,15 +85,7 @@ public void ClearAssignees()
         /// <param name="name">The login of the assignee to remove</param>
         public void RemoveAssignee(string name)
         {
-            // lazily create the assignees array
-            if (Assignees == null)
-            {
-                Assignees = new List<string>();
-            }
-            else
-            {
-                Assignees.Remove(name);
-            }
+            Assignees.Remove(name);
         }
 
         /// <summary>
@@ -120,12 +94,6 @@ public void RemoveAssignee(string name)
         /// <param name="name">The name of the label.</param>
         public void AddLabel(string name)
         {
-            // lazily create the label array
-            if (Labels == null)
-            {
-                Labels = new List<string>();
-            }
-
             Labels.Add(name);
         }
 
@@ -134,15 +102,7 @@ public void AddLabel(string name)
         /// </summary>
         public void ClearLabels()
         {
-            // lazily create the label array
-            if (Labels == null)
-            {
-                Labels = new List<string>();
-            }
-            else
-            {
-                Labels.Clear();
-            }
+            Labels.Clear();
         }
 
         /// <summary>
@@ -151,15 +111,7 @@ public void ClearLabels()
         /// <param name="name">The name of the label to remove</param>
         public void RemoveLabel(string name)
         {
-            // lazily create the label array
-            if (Labels == null)
-            {
-                Labels = new List<string>();
-            }
-            else
-            {
-                Labels.Remove(name);
-            }
+            Labels.Remove(name);
         }
     }
 }