Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's Left To Implement? #246

Closed
shiftkey opened this issue Nov 30, 2013 · 14 comments
Closed

What's Left To Implement? #246

shiftkey opened this issue Nov 30, 2013 · 14 comments
Assignees

Comments

@shiftkey
Copy link
Member

I'm sure there's some things we've overlooked

@ghost ghost assigned shiftkey Nov 30, 2013
@andrerod andrerod mentioned this issue Dec 4, 2013
@hnrkndrssn
Copy link
Contributor

So I started going through the API doco to see what's missing in the current master branch, I only got to Pull Requests, I'll go through the rest tonight.

NOTE I haven't crossreferenced with current PRs yet, will do that as well and put a reference next to any items that have PRs against them.

Alright, I think this is the list of what's left to do, and any related PRs that exists.

Activities

IGistClient #328

ITreesClient #329

IIssueCommentsClient

IIssuesLabelsClient

IOrganizationsClient #330

ITeamsClient #331

Pull Requests

IRepositoriesClient

Repositories

Search

Users

@shiftkey
Copy link
Member Author

Oh @alfhenrik you are awesome! Thanks for taking the time to do this...

@hnrkndrssn
Copy link
Contributor

Aww shucks! 😊 🎇

@hnrkndrssn
Copy link
Contributor

@shiftkey alright, list updated with what I think is THE list of outstanding items to be completed ;) You'll have it done by the weekend right, with busted hand and all? 😬

@haacked
Copy link
Contributor

haacked commented Jan 21, 2014

This is fantastic! We should probably create an issue per client. That way we can start pushing for new contributors to jump in. :)

@hnrkndrssn
Copy link
Contributor

Sounds like a good plan 👍

@shiftkey
Copy link
Member Author

Oh, and I just realised that we might need to review that the IObservable versions are also in sync.

But that's just wrapping these, so I'm happy to push that out til after this.

@hnrkndrssn
Copy link
Contributor

I can have a look at those when I get back from work!

@pmacn
Copy link

pmacn commented Jan 21, 2014

http://developer.github.com/v3/repos/#list-branches
looks as if it's already implemented

just noticed as I was working on the repository ones

@shiftkey
Copy link
Member Author

@pmacn correct! (I've pulled it from the list)

924543d

@khellang
Copy link
Contributor

we might need to review that the IObservable versions are also in sync

Sounds like a unit convention test 😉

@shiftkey
Copy link
Member Author

@khellang opened: #317

@pmacn
Copy link

pmacn commented Jan 22, 2014

@alfhenrik #319 should cover all of the ones listed under IRepositoriesClient

@shiftkey
Copy link
Member Author

Closing this as the tasks identified have been spun off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants