Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SearchCodeRequest to match the API #311

Merged
merged 4 commits into from
Jan 22, 2014
Merged

Refactor SearchCodeRequest to match the API #311

merged 4 commits into from
Jan 22, 2014

Conversation

hnrkndrssn
Copy link
Contributor

  • no longer subclass RequestParameters, but expose a Parameters property and build it up similar to how SearchRepositoriesRequest works
  • re-add the Sort property
  • add some tests

Fixes #275

@anaisbetts
Copy link
Contributor

Your use of not-completely-finished PRs with TODOs is 💖 +💯

@hnrkndrssn
Copy link
Contributor Author

Well, I've learnt from the best 😀 ❤️

@hnrkndrssn
Add unit tests
9d03766 
And make sure that the Forks property returns a lowercase representation
of it's value...
@hnrkndrssn hnrkndrssn mentioned this pull request Jan 21, 2014
Closed
@shiftkey
Copy link
Member

Thanks!

shiftkey added a commit that referenced this pull request Jan 22, 2014
@shiftkey
Merge pull request #311 from alfhenrik/search-code-req
b57a60b 
Refactor SearchCodeRequest to match the API
@shiftkey shiftkey merged commit b57a60b into octokit:master Jan 22, 2014
@hnrkndrssn hnrkndrssn deleted the search-code-req branch January 22, 2014 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completing "Search Code" API
3 participants
@hnrkndrssn @anaisbetts @shiftkey