Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move GitHubAppInstallationsClient into root namespace #2131

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 6, 2020

A follow-up from #2128 for a case that wasn't caught by our conventions, because it was created in the Octokit.Clients namespace rather than the root Octokit namespace.

This updates the namespace and adds the necessary route attributes to get the build passing again.

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #2131 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2131      +/-   ##
==========================================
- Coverage   66.85%   66.84%   -0.02%     
==========================================
  Files         543      543              
  Lines       14230    14230              
==========================================
- Hits         9514     9512       -2     
- Misses       4716     4718       +2
Impacted Files Coverage Δ
Octokit/Clients/GitHubAppsClient.cs 84.84% <ø> (ø) ⬆️
Octokit/Clients/GitHubAppInstallationsClient.cs 75% <ø> (ø) ⬆️
Octokit/SimpleJson.cs 70.15% <0%> (-0.27%) ⬇️

@shiftkey shiftkey merged commit 216e4e3 into master Mar 6, 2020
@shiftkey shiftkey deleted the misnamed-client branch March 6, 2020 13:30
@shiftkey
Copy link
Member Author

release_notes: move GitHubAppInstallationsClient into root namespace

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants