-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gist get support #225
Add gist get support #225
Conversation
var retrieved = await this._gistsClient.Get(6305249); | ||
Assert.NotNull(retrieved); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W H I T E S P A C E
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And let's assert a little more than it's not null. 😄
@shiftkey well I only needed the next thing I need is http://developer.github.com/v3/git/ is anyone working on this? |
I'm cool with that. Stub out out the other methods with a
Blobs and Trees are underway #188 and #194 - which I'll review again and probably merge in today for a 0.1.5 release early next week. |
@shiftkey so can this be merged? |
In it's current form, the magic "Merge pull request" button is disabled. I think the .csproj changes from I'll also just run through the latest changes just in case I missed something. |
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get", | ||
Justification = "Method makes a network request")] | ||
Task<Gist> Get(string id); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a little less whitespace
Oh, and run |
|
@SimonCropp do a cc @forki to remind me to review that script and try-catch the way out |
same error seems u have a bunch of stuff that assume existence of |
@SimonCropp I'm able to see this issue on |
sooo. can we merge this one ;) |
Build.cmd is prompting. I thought we removed that prompt. It shouldn't have any sort of user interaction like that. |
Actually I broke fake for one or two hours. Sorry about that. Maybe you got a broken version. Can you delete tools/fake and retry? |
It still is. Let me fix it. @SimonCropp your @forki I'm still seeing the 0KB file be downloaded to the local cache - are you able to publish a new release? |
@shiftkey yep i have a 0byte file. |
Still broken?? Wtf |
@forki did u unlist 757? 756 looks good but i cant see 757. if u want to get nuget to fix it u prob need to push a fixed version with a higher number than the broken one |
Running
That closing brace is causing some compile issues. |
I'm really sorry. I hope it works now. Something broke during nuget push. It teaches me a lesson to finally release FAKE 2.0 in order to detach the important projects from the prerelease channel. |
@shiftkey so the projects are now synced. anything else? |
@SimonCropp I'm still seeing the broken @forki is there something I'm missing? |
This is so embarrassing. I reverted FAKE to a good version. Octokit now builds on my machine. I promise to release FAKE 2 today and then we can move Octokit and other important projects on the stable release channel. I'm really sorry that I broke it. But I will give my best to improve it. |
@forki that's fine - happens to the best of us. Let me know when it's 🆒 and we can try again |
Thanks. Please try again the "good" (old) version is already on nuget. |
@forki got it @SimonCropp looks good, would be nice to test that some of the properties on the gist response - like Let's see if @haacked has any issues |
@shiftkey well my intent was actually to do some serialization tests on a future PR. but I initially wanted to "make it work" then iterate on that |
Fine with me |
No description provided.