Search Api Implmentation

[hahmed]

http://developer.github.com/v3/search/

I think we need to 💥 #203 (base was messed up).

Issue #137

Searching code issues repos and users.

I have implemented all the above with a basic search without any qualifiers added, however in this PR I have added all the qualifiers for searching repos. Below is a full list of what has been implemented for repo search.

Repo Qualifiers -> https://help.github.com/articles/searching-repositories

• https://help.github.com/articles/searching-repositories#search-in
• https://help.github.com/articles/searching-repositories#size
• https://help.github.com/articles/searching-repositories#forks FORKs
• https://help.github.com/articles/searching-repositories#forks FORK
• https://help.github.com/articles/searching-repositories#created-and-last-updated
• https://help.github.com/articles/searching-repositories#users-organizations-and-repositories
• https://help.github.com/articles/searching-repositories#languages
• https://help.github.com/articles/searching-repositories#stars
• https://help.github.com/articles/searching-repositories#sorting
• Unit Tests for all of above

Note to self
To do: Any qualifiers related to code/users/issues search.
@shiftkey may want this to be in separate PR's, will need to confirm then update this.

[hahmed]

The only thing I need some review on is #203 (comment)

[hahmed]

@haacked that's all in now and I have merged into master.

Let me know what else you want me to do to get this merged in.

Thanks

[shiftkey]

@hahmed I'll give it a closer look this afternoon (will be in transit but online wherever possible)

[hahmed]

@shiftkey cool let me know what you got I made some of those fixes anyway. With regards to optional ctor args [https://github.com//pull/226#commitcomment-4738657] @haacked mentioned to not do that here #226 (comment) [one of the diff comments - quoting some of it below].

Please don't suppress this one. For more details: http://haacked.com/archive/2010/08/10/versioning-issues-with-optional-arguments.aspx

The constructor should only have parameters that are required. The caller can set the properties of the object for all the optional fields.

If you want I can add some overloads but I don't think that will be of any benefit? Optional args are better but we are trying to avoid what @haacked said so the next best thing is to instantiate the Search Request with only the search term then customize your search however you want - we don't care.

Note - if we go down this route we will offer some consistency to our users with the 3 other search requests (code, issues and users).

I have one suggestion that will work sweetly - that would be to instantiate the object then maybe chain the other search terms.

var search = new SearchRepositoriesRequest("octoko")
                         .In(new[] { InQualifier.Description })
                         .Size(whatever)
                         .Language(Lanugage,Go);

If that can even be implemented like that?

Let me know what you are thinking with this...

[hahmed]

@haacked @shiftkey do you guys feel this is good to merge? 😄

[shiftkey]

@hahmed I'll have a look at it tomorrow while I'm waiting for a flight

[hahmed]

@shiftkey ok cool thanks.

Sorry if I did a bit too much work on this in one go - I should have broken it down into smaller steps by doing a simple search then gone on to extend the searching in more detail in simple digestible PR's. Lesson learnt though.

[haacked]

@hahmed looks like you'll need to update this branch from upstream master.

[hahmed]

@hahmed looks like you'll need to update this branch from upstream master.

@haacked that's done.

[hahmed]

@haacked @shiftkey if there is anything I can do to help push this along please let me know. I have updated this with the master branch now.

[shiftkey]

EDIT: nevermind, I'd rather get this in and then tidy up the docs for the next release.

[shiftkey]

Ok, I'm gonna land this one in master and open some issues to track tidying up things like

• getting documentation more consistent
• integration tests
• code tidy-up and consistency

This will help us iterate over the search API as we charge towards V1.

Thanks for the hard work on this.

[hahmed]

@shiftkey it's cool, if you want. You can cc me in anything.

I have a few other things I need to do I will look to implement them in smaller portions hopefully. (if anyone else has not taken the issue).

[hahmed]

@shiftkey can the branch hahmed/search-api be removed please - mistake on my part. Thanks

[shiftkey]

@hahmed I'm not clear on what you need me to do. I can't see the branch listed here so I assume you tidied it up:

https://github.com/hahmed/octokit.net/branches

[hahmed]

@shiftkey sorry I should have been more clearer - I meant https://github.com/octokit/octokit.net/tree/hahmed/search-api

[shiftkey]

Ah, yes. Don't stress about those, they're easy to clean up...