Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gist Comments API #252

Merged
merged 9 commits into from
Dec 2, 2013
Merged

Gist Comments API #252

merged 9 commits into from
Dec 2, 2013

Conversation

khellang
Copy link
Contributor

@khellang khellang commented Dec 1, 2013

Here's an implementation of the gist comments API. The only thing missing should be some integration tests, I can add that later if you want 😄

haacked added a commit that referenced this pull request Dec 2, 2013
@haacked haacked merged commit 185589e into octokit:master Dec 2, 2013
@haacked
Copy link
Contributor

haacked commented Dec 2, 2013

Thanks!

thumbup-troy

@haacked
Copy link
Contributor

haacked commented Sep 27, 2015

@khellang Can you remind me why we needed the BodyWrapper class?

@khellang khellang deleted the feature/gist-comments branch September 28, 2015 07:44
@khellang
Copy link
Contributor Author

Uuuh. I don't really remember 😕 I think it might be because the API expects an object and not just a string;

{
  "body": "Just commenting for the sake of commenting"
}

Is it causing problems?

@haacked
Copy link
Contributor

haacked commented Sep 28, 2015

Ah, right. Maybe BodyResponse is a better name, but no need to change it for now.

@khellang
Copy link
Contributor Author

If anything, it's a BodyRequest 😉

return ApiConnection.Post<GistComment>(ApiUrls.GistComments(gistId), new BodyWrapper(comment));

@haacked
Copy link
Contributor

haacked commented Sep 28, 2015

Or RequestBody!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants