Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: The methods GetAllForCurrentWithTimestamps and GetAllForUserWithTimestamps did not return timestamps. #2829

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

MareMare
Copy link
Contributor

@MareMare MareMare commented Dec 11, 2023

Resolves #2827


Before the change?

StarredClient.GetAllForCurrentWithTimestamps and StarredClient.GetAllForUserWithTimestamps expect to be returned with the StarredAt and Repo properties set, but default values are returned.

image

After the change?

The StarredAt and Repo property values are returned with the received values set.

image

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Jan 2, 2024
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @MareMare ❤️

@nickfloyd nickfloyd merged commit 3e92a69 into octokit:main Jan 2, 2024
5 checks passed
@MareMare MareMare deleted the fix/2827 branch January 4, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: The methods GetAllForCurrentWithTimestamps and GetAllForUserWithTimestamps did not return timestamps.
2 participants