feat: added Missing APIOption overload for PackagesClient.GetAll* #2923 #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tokit#2923 added missing APIOption overload for PackagesClient and ObservablePackagesClient added overload for optional parameter packageVisibility to be a nonbreaking change extended PackagesClientTests.cs to be conform with RepositoriesClientTests.cs to take ApiOptions into account
kfcampbell
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Thanks for contributing.
[ExcludeFromPaginationApiOptionsConventionTest("No api options available according to the documentation")]
This is interesting to see, since the docs definitely support taking page and per_page. I wonder if it didn't used to be supported and changed at some point recently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2923
Before the change?
PackagesClient.GetAll*were not able to paginate and the results capped at 30 resultsAfter the change?
Overload parameter
APIOptionsforPackagesClient.GetAll*Methods. Extended the Tests for
PackagesClient.GetAll*to behave the same asRepositoriesClient.GetAll*.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!