Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate IGitHubClient.Blob #305

Merged
merged 1 commit into from
Jan 14, 2014
Merged

Deprecate IGitHubClient.Blob #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Octokit.Reactive/Clients/ObservableBlobClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public ObservableBlobClient(IGitHubClient client)
{
Ensure.ArgumentNotNull(client, "client");

_client = client.Blob;
_client = client.GitDatabase.Blob;
}

/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Octokit.Tests/Reactive/ObservableBlobClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public void GetsFromClientIssueComment()

client.Get("fake", "repo", "123456ABCD");

gitHubClient.Blob.Received().Get("fake", "repo", "123456ABCD");
gitHubClient.GitDatabase.Blob.Received().Get("fake", "repo", "123456ABCD");
}

[Fact]
Expand Down Expand Up @@ -48,7 +48,7 @@ public void PostsToCorrectUrl()

client.Create("fake", "repo", newBlob);

gitHubClient.Blob.Received().Create("fake", "repo", newBlob);
gitHubClient.GitDatabase.Blob.Received().Create("fake", "repo", newBlob);
}

[Fact]
Expand Down
2 changes: 0 additions & 2 deletions Octokit/GitHubClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ public GitHubClient(IConnection connection)
var apiConnection = new ApiConnection(connection);
Authorization = new AuthorizationsClient(apiConnection);
Activity = new ActivitiesClient(apiConnection);
Blob = new BlobsClient(apiConnection);
Issue = new IssuesClient(apiConnection);
Miscellaneous = new MiscellaneousClient(connection);
Notification = new NotificationsClient(apiConnection);
Expand Down Expand Up @@ -132,7 +131,6 @@ public Uri BaseAddress

public IAuthorizationsClient Authorization { get; private set; }
public IActivitiesClient Activity { get; private set; }
public IBlobsClient Blob { get; private set; }
public IIssuesClient Issue { get; private set; }
public IMiscellaneousClient Miscellaneous { get; private set; }
public IOrganizationsClient Organization { get; private set; }
Expand Down
1 change: 0 additions & 1 deletion Octokit/IGitHubClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ public interface IGitHubClient

IAuthorizationsClient Authorization { get; }
IActivitiesClient Activity { get; }
IBlobsClient Blob { get; }
IIssuesClient Issue { get; }
IMiscellaneousClient Miscellaneous { get; }
IOrganizationsClient Organization { get; }
Expand Down