Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement User Followers API #343

Merged
merged 11 commits into from
Feb 2, 2014
Merged

Implement User Followers API #343

merged 11 commits into from
Feb 2, 2014

Conversation

hnrkndrssn
Copy link
Contributor

  • Stub out the User Followers API
  • Implement the User Followers API
  • Write some tests
  • Implement the Observable User Followers API
  • Write some more tests
  • Write some integration tests

Fixes #339

@hnrkndrssn
Copy link
Contributor Author

I'm not quite sure about the naming of the API client, maybe FollowersClient would be a better name...feedback appreciated. ✨

@hnrkndrssn
Copy link
Contributor Author

This is pretty much ready for a review while I write up some integration tests 😄

cc @shiftkey

@shiftkey
Copy link
Member

I'm not quite sure about the naming of the API client, maybe FollowersClient would be a better name...

As Followers are a concept only relevant to users - you can have watchers and stargazers on repositories - I'm happy to simplify it to IFollowersClient

@hnrkndrssn
Copy link
Contributor Author

👍 I'll get on that tonight

@hnrkndrssn
Copy link
Contributor Author

I think that should do it now 😄

shiftkey
shiftkey reviewed Jan 30, 2014
View reviewed changes
Octokit/Clients/FollowersClient.cs
/// See the <a href="http://developer.github.com/v3/users/followers/#list-users-followed-by-another-user">API documentation</a> for more information.
/// </remarks>
/// <returns></returns>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Globalization", "CA1305:SpecifyIFormatProvider", MessageId = "System.String.Format(System.String,System.Object[])"), System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Globalization", "CA1305:SpecifyIFormatProvider", MessageId = "System.String.Format(System.String,System.Object)")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 this line

@hnrkndrssn
Copy link
Contributor Author

Here goes 🙏

@hnrkndrssn
Copy link
Contributor Author

@shiftkey when you got a ⏳ could you cast your 👀 over this one, I've merged in the latest changes from master so this should be ✅ now

@shiftkey
Copy link
Member

shiftkey commented Feb 1, 2014

The build is sad...

       "C:\Users\half-ogre\GitHub\qed\qed\bin\Release\.repositories\octokit\octokit.net\Octokit.sln" (Build target) (1) ->
       "C:\Users\half-ogre\GitHub\qed\qed\bin\Release\.repositories\octokit\octokit.net\Octokit\Octokit-Mono.csproj" (default target) (9) ->
       (CoreCompile target) -> 
         CSC : error CS2001: Source file 'Clients\IUserFollowersClient.cs' could not be found [C:\Users\half-ogre\GitHub\qed\qed\bin\Release\.repositories\octokit\octokit.net\Octokit\Octokit-Mono.csproj]
         CSC : error CS2001: Source file 'Clients\UserFollowersClient.cs' could not be found [C:\Users\half-ogre\GitHub\qed\qed\bin\Release\.repositories\octokit\octokit.net\Octokit\Octokit-Mono.csproj]

@hnrkndrssn
Copy link
Contributor Author

Dem projects got me again :'(

From: Brendan Forster
Sent: 1/02/2014 10:07
To: octokit/octokit.net
Cc: Henrik Andersson
Subject: Re: [octokit.net] Implement User Followers API (#343)

The build is sad...

       "C:\Users\half-ogre\GitHub\qed\qed\bin\Release\.repositories\octokit\octokit.net\Octokit.sln" (Build target) (1) ->
       "C:\Users\half-ogre\GitHub\qed\qed\bin\Release\.repositories\octokit\octokit.net\Octokit\Octokit-Mono.csproj" (default target) (9) ->
       (CoreCompile target) ->
         CSC : error CS2001: Source file 'Clients\IUserFollowersClient.cs' could not be found [C:\Users\half-ogre\GitHub\qed\qed\bin\Release\.repositories\octokit\octokit.net\Octokit\Octokit-Mono.csproj]
         CSC : error CS2001: Source file 'Clients\UserFollowersClient.cs' could not be found [C:\Users\half-ogre\GitHub\qed\qed\bin\Release\.repositories\octokit\octokit.net\Octokit\Octokit-Mono.csproj]

Reply to this email directly or view it on GitHub:
#343 (comment)

haacked
haacked reviewed Feb 2, 2014
View reviewed changes
Octokit/Helpers/ApiUrls.cs
@@ -833,5 +833,35 @@ public static Uri SearchCode()
{
return "search/code".FormatUri();
}

public static Uri Followers()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding doc comments to these methods?

haacked added a commit that referenced this pull request Feb 2, 2014
@haacked
Merge pull request #343 from alfhenrik/user-followers-api
5eebdfa 
Implement User Followers API
@haacked haacked merged commit 5eebdfa into octokit:master Feb 2, 2014
@haacked
Copy link
Contributor

haacked commented Feb 2, 2014

Nice! Very clean. If you don't mind, I made some comments about the lack of comments. If you have time to address those in another PR, that'd be great.

@hnrkndrssn
Copy link
Contributor Author

Yep I'll address your comments in a separate PR :-)

From: Phil Haack
Sent: 2/02/2014 10:18
To: octokit/octokit.net
Cc: Henrik Andersson
Subject: Re: [octokit.net] Implement User Followers API (#343)

Nice! Very clean. If you don't mind, I made some comments about the lack of comments. If you have time to address those in another PR, that'd be great.

Reply to this email directly or view it on GitHub:
#343 (comment)

@hnrkndrssn hnrkndrssn mentioned this pull request Feb 2, 2014
Merged
@hnrkndrssn hnrkndrssn deleted the user-followers-api branch September 18, 2015 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement User Followers API
3 participants
@hnrkndrssn @shiftkey @haacked