Implement missing functions in Repo Releases API #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <param name="number">The id of the release</param> | ||
| /// <exception cref="ApiException">Thrown when a general API error occurs.</exception> | ||
| /// <returns>The <see cref="Release"/> specified by the id</returns> | ||
| [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] |
There was a problem hiding this comment.
I'm starting to wonder if we should just disable CA1716. @shiftkey any thoughts?
|
Looking good so far. Just realized this is still WIP. :) |
|
Thanks, always good to get an early review done, gives me more time to fix it up 😁 |
Add API URLs to comments Doc Comment Observable Releases Client Add API URLs to doc comments Code Analysis fixes
|
Just adding some integration tests, other than that this is ready for review. |
haacked
added a commit
that referenced
this pull request
Feb 7, 2014
Implement missing functions in Repo Releases API
|
Feel free to add the integration tests in another PR. Nice work! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #338