Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convention Tests - Part Deux #376

Merged
merged 14 commits into from
Feb 20, 2014
Merged

Conversation

shiftkey
Copy link
Member

Before I can officially integrate the Convention Tests into the build, the convention tests should actually pass. Crazy, I know...

This PR addresses that issue.

Resolves #370 and #361

@shiftkey
Copy link
Member Author

I'll merge master into this tomorrow, but aside from that I think this is ready for review

@haacked
Copy link
Contributor

haacked commented Feb 19, 2014

We might want to add more information when the assert fails. Here's an example I got today.

System.Exception : Missing observable methods
---- Assert.Equal() Failure
Expected: String[] { }
Actual: String[] { "get_Email" }

Not sure what to do with that.

@shiftkey
Copy link
Member Author

It's green, quick, ship it @haacked!

haacked added a commit that referenced this pull request Feb 20, 2014
@haacked haacked merged commit c048349 into master Feb 20, 2014
@haacked haacked deleted the shiftkey/convention-tests-part-deux branch February 20, 2014 00:49
@haacked
Copy link
Contributor

haacked commented Feb 20, 2014

👍 Thanks @shiftkey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add convention tests to the .\script\cibuild.ps1 script
2 participants