Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparing commits tags branches #433

Closed
wants to merge 3 commits into from
Closed

Add comparing commits tags branches #433

wants to merge 3 commits into from

Conversation

hknielsen
Copy link

Issue:
#432

I have added the compare and tests. Ive made the model out from the json.

Uses:
http://developer.github.com/v3/repos/commits/#compare-two-commits


namespace Octokit
{
[DebuggerDisplay("{DebuggerDisplay,nq}")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This attribute requires that you actually have a private (or internal) property named DebuggerDisplay that returns a string. We usually only show a couple property values in such a property. The ones you'd want most to see in a debugger.

@haacked
Copy link
Contributor

haacked commented Mar 18, 2014

Thanks so much for submitting a pull request! I really appreciate it. There's a few comments I made on it.

@hknielsen
Copy link
Author

no problem, nice work :) ive updated from the comments,pushed it too fast without reviewing it myself :D so thanks for the the comments

@hknielsen
Copy link
Author

Hmm somehow the projects:
Octokit-Monotouch
Octokit-MonoAndroid

Fails for me, I cant open them in VS, but then I wonder why all the projects need them added, why not have a model assembly so they automatically added?

@haacked
Copy link
Contributor

haacked commented Mar 18, 2014

Run build.cmd FixProjects and commit changes.

@hknielsen
Copy link
Author

Done :) thanks awesome!

@shiftkey
Copy link
Member

There's definitely some overlap between this and #428

@hknielsen
Copy link
Author

@shiftkey @haacked Yes perfect, good that it isnt a complex implementation :) If you just change your model ill close my pull request

@hknielsen
Copy link
Author

Closing pull request cause duplicate in logic from #428

@hknielsen hknielsen closed this Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants