-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comparing commits tags branches #433
Add comparing commits tags branches #433
Conversation
|
||
namespace Octokit | ||
{ | ||
[DebuggerDisplay("{DebuggerDisplay,nq}")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This attribute requires that you actually have a private (or internal) property named DebuggerDisplay
that returns a string. We usually only show a couple property values in such a property. The ones you'd want most to see in a debugger.
Thanks so much for submitting a pull request! I really appreciate it. There's a few comments I made on it. |
no problem, nice work :) ive updated from the comments,pushed it too fast without reviewing it myself :D so thanks for the the comments |
Hmm somehow the projects: Fails for me, I cant open them in VS, but then I wonder why all the projects need them added, why not have a model assembly so they automatically added? |
Run build.cmd FixProjects and commit changes. |
Done :) thanks awesome! |
There's definitely some overlap between this and #428 |
Closing pull request cause duplicate in logic from #428 |
Issue:
#432
I have added the compare and tests. Ive made the model out from the json.
Uses:
http://developer.github.com/v3/repos/commits/#compare-two-commits