Fix regression in throwing proper 2FA exception #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 451eddc we were a little overzealous in removing async/await calls. Anywhere we do a try/catch around a method that returns a Task, we need to use await.
We don't need to await tests of argument validation. But we do need to await tests that test exceptions returned from a task.
|
Nice 👀 there @haacked! |
shiftkey
added a commit
that referenced
this pull request
Mar 21, 2014
Fix regression in throwing proper 2FA exception
|
Thanks @shiftkey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 451eddc we were a little overzealous in removing async/await calls. Anywhere we do a try/catch around a
method that returns a Task, we need to use await.