Fix compatibility with Ruby 3.4

But also older Rubies if the default URI parser is set to `RFC3986`.
octokit · Jul 23, 2024 · a4bae88 · a4bae88
1 parent a255895
commit a4bae88
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lib/octokit/repository.rb b/lib/octokit/repository.rb
@@ -81,8 +81,14 @@ def url
 
     private
 
+    ABS_URI_REGEXP = if URI.const_defined?(:RFC2396_PARSER) # Ruby 3.4+
+                       URI::RFC2396_PARSER.regexp.fetch(:ABS_URI)
+                     else
+                       URI::RFC2396_Parser.new.regexp.fetch(:ABS_URI)
+                     end
+
     def validate_owner_and_name!(repo)
-      if @owner.include?('/') || @name.include?('/') || !url.match(URI::ABS_URI)
+      if @owner.include?('/') || @name.include?('/') || !url.match?(ABS_URI_REGEXP)
         raise_invalid_repository!(repo)
       end
     end