Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faraday deprecation notice #1170

Closed
orien opened this issue Nov 28, 2019 · 4 comments
Closed

Faraday deprecation notice #1170

orien opened this issue Nov 28, 2019 · 4 comments

Comments

@orien
Copy link

orien commented Nov 28, 2019 •
edited
Loading

When collaborating with Faraday version 0.17.1 a deprecation notice is printed to STDERR:

NOTE: Inheriting Faraday::Error::ClientError is deprecated; use Faraday::ClientError instead. It will be removed in or after version 1.0
Faraday::Error::ClientError.inherited called from /usr/local/bundle/gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:14.
@orien
Copy link
Author

orien commented Nov 28, 2019

I see this has been resolved in #1154. Any chance of a release?

@DannyBen DannyBen mentioned this issue Dec 7, 2019
Closed
DannyBen added a commit to DannyBen/madman that referenced this issue Dec 12, 2019
@DannyBen
restrict faraday due to octokit/octokit.rb#1170
26b921e
@DannyBen DannyBen mentioned this issue Dec 12, 2019
Closed
@jonatanklosko jonatanklosko mentioned this issue Dec 13, 2019
Merged
cetinajero added a commit to cetinajero/jekyll-theme-marketing that referenced this issue Dec 18, 2019
@cetinajero
Supress stdout warnings due to faraday dependency
98716f0 
See: octokit/octokit.rb#1170
jsvd added a commit to elastic/docs-tools that referenced this issue Jan 2, 2020
@jsvd
restrict faraday to 0.x
95e4a31 
This is because of a breaking change in faraday 1.0
that is not supported in octokit.rb at the time of this commit

See more in octokit/octokit.rb#1170
@cetinajero
Copy link

cetinajero commented Jan 2, 2020 •
edited
Loading

Hi @orien,

The faraday team had released v0.17.3 which by default doesn't show those warnings (requires a FARADAY_DEPRECATE=warn env variable to show them).

More on that here: lostisland/faraday#1098

You can also wait for an octokit release next weak!

cetinajero added a commit to cetinajero/jekyll-theme-marketing that referenced this issue Jan 2, 2020
@cetinajero
Update to faraday v0.17.3 to avoid octokit warnings
69a3476 
ref: octokit/octokit.rb#1170 (comment)
@indigok
Copy link

indigok commented Jan 2, 2020

A new release has now been cut, v4.15.0. See #1177 (comment). ✨

@indigok indigok closed this as completed Jan 2, 2020
@orien
Copy link
Author

orien commented Jan 13, 2020

Thanks!

@adfoster-r7 adfoster-r7 mentioned this issue Mar 17, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@orien @indigok @cetinajero