Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth via username and password is now obsolete #1313

Closed
curquiza opened this issue Dec 22, 2020 · 2 comments · Fixed by #1314
Closed

Auth via username and password is now obsolete #1313

curquiza opened this issue Dec 22, 2020 · 2 comments · Fixed by #1314

Comments

@curquiza
Copy link
Contributor

Since GitHub stopped maintaining basic auth via username and password:

Note: GitHub has discontinued password authentication to the API starting on November 13, 2020 for all GitHub.com accounts, including those on a GitHub Free, GitHub Pro, GitHub Team, or GitHub Enterprise Cloud plan. You must now authenticate to the GitHub API with an API token, such as an OAuth access token, GitHub App installation access token, or personal access token, depending on what you need to do with the token. For more information, see "Troubleshooting."

Ref: https://docs.github.com/en/free-pro-team@latest/rest/overview/other-authentication-methods#via-username-and-password

Should this package keep maintaining authentication via username and password? Shouldn't the main way to authenticate be via PAT?

I would be happy to do a PR 🙂

@curquiza
Copy link
Contributor Author

Since we can pass the PAT in password

client = Octokit::Client.new(:login => 'curquiza', :password => 'github_pat')

I'm not sure doing changes in the code would be useful changes, plus they would be breaking.

But I still can open a PR to make the README more up-to-date.

@curquiza
Copy link
Contributor Author

I opened #1314
Feel free to refuse or request any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant