Update README to remove Octokit client instance creation with username and password. #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarebyte
requested changes
May 11, 2021
Co-authored-by: Mark Tareshawty <tarebyte@github.com>
Co-authored-by: Mark Tareshawty <tarebyte@github.com>
tarebyte
approved these changes
May 15, 2021
|
👋🏻 We thank you for helping us keep our library up to date! However, these comments were added as part of #1313 to address the username/password deprecation and are still a valid way to authenticate! Thus, I've opened up a PR to revert them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of November 2020, the GitHub API does not allow you to authenticate to the API via username and password. See https://github.blog/changelog/2020-11-13-token-authentication-required-for-api-operations/ for more details.
Therefore login with user and password must be removed from the README file of the project.