Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 failure for netrc auth in 4.22.0 #1409

Closed
ivanboykoatitv opened this issue Apr 4, 2022 · 3 comments
Closed

404 failure for netrc auth in 4.22.0 #1409

ivanboykoatitv opened this issue Apr 4, 2022 · 3 comments
Labels
Status: Stale Used by stalebot to clean house Type: Bug Something isn't working as documented

Comments

@ivanboykoatitv
Copy link

ivanboykoatitv commented Apr 4, 2022

We use ~/.netrc for authentication with GitHub.

      client = Octokit::Client.new(netrc: true)
      client.get_public_key("....")

It works fine with octokit version 4.21.0 but fails with version 4.22.0:

Octokit::NotFound: GET https://api.github.com/repos/***/***/actions/secrets/public-key: 404 - Not Found // See: https://docs.github.com/rest/reference/actions#get-a-repository-public-key
~/.rbenv/versions/2.7.1/bin/bundle:23:in `load'
~/.rbenv/versions/2.7.1/bin/bundle:23:in `<main>'

Manual curl using netrc authentication also works fine:

curl -n https://api.github.com/repos/***/***/actions/secrets/public-key
@timrogers
Copy link
Contributor

@ivanboykoatitv Thanks for reporting this issue! There are only rather limited changes between v4.21.0 and v4.22.0, so I would be surprised if it broke .netrc authentication. Would you be able to double check that you can reproduce the issue?

@timrogers timrogers added the bug label Apr 26, 2022
@timrogers
Copy link
Contributor

On second thoughts, I think this is probably related to #1392. Do you know which Faraday version you're using? You should be able to see that in your Gemfile.lock.

@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed bug labels Oct 28, 2022
@github-actions
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Jul 26, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house Type: Bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

3 participants