Allow Faraday v2 usage #1411
Merged
Allow Faraday v2 usage #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarsh-tenjin
approved these changes
Apr 20, 2022
|
octokit was returning 404 not found issue and this issue is been surfacing for a week. I updated faraday in other dependencies of a project. Which did resolve the issue. as i find faraday is being used in octokit. @tisba please review this PR when you have time. Thank you in advance. |
tisba
approved these changes
Apr 20, 2022
BobbyMcWho
reviewed
Apr 20, 2022
Bo98
reviewed
Apr 21, 2022
| module Octokit | ||
| module Response | ||
| # In Faraday 2.x, Faraday::Response::Middleware was removed | ||
| BaseMiddleware = defined?(Faraday::Response::Middleware) ? Faraday::Response::Middleware : Faraday::Middleware |
There was a problem hiding this comment.
Worth noting that Faraday::Middleware can be used as far back as v1.2.0: lostisland/faraday@d56742a
Bo98
reviewed
Apr 21, 2022
Comment on lines
+7
to
+13
| if Gem::Version.new(Faraday::VERSION) >= Gem::Version.new('2.0') | ||
| begin | ||
| require 'faraday/retry' | ||
| rescue LoadError | ||
| Octokit::Warnable.octokit_warn 'To use retry middleware with Faraday v2.0+, install `faraday-retry` gem' | ||
| end | ||
| end |
There was a problem hiding this comment.
Is faraday-retry usable on Faraday 1.x? I wonder if it makes sense to just add it as a dependency if so.
Co-authored-by: Bobby McDonald <BobbyMcWho@users.noreply.github.com>
mattpage
approved these changes
May 26, 2022
5 tasks
dentarg
added a commit
to Starkast/wikimum
that referenced
this pull request
Jul 10, 2023
No breaking changes really in the major versions - https://github.com/octokit/octokit.rb/releases/tag/v6.0.0 - https://github.com/octokit/octokit.rb/releases/tag/v5.0.0 The breaking changes happened with the move to Faraday 2: - octokit/octokit.rb#1411 - octokit/octokit.rb#1392 - http://patrik.codes/2022/octokit
dentarg
added a commit
to Starkast/wikimum
that referenced
this pull request
Jul 10, 2023
No breaking changes really in the major versions - https://github.com/octokit/octokit.rb/releases/tag/v6.0.0 - https://github.com/octokit/octokit.rb/releases/tag/v5.0.0 The breaking changes happened with the move to Faraday 2: - octokit/octokit.rb#1411 - octokit/octokit.rb#1392 - http://patrik.codes/2022/octokit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Faraday v2 this PR:
~> 0.16.0which shouldn't be a big deal since it was a reverted release: v0.17.0 looks to be a bad release lostisland/faraday#1049 (versions< 0.16.0and~> 0.17.0are already not supported byoctokit)sawyerform~> 0.8.0to~> 0.9.0faraday-retryis present and warns user if gem is not installedThis PR is a successor to #1358