Add cross-support for Faraday 1.x.x and 2.x.x

[ashishkeshan]

With the merge of: #1359 to silenece deprecation warnings, and based on the comment here: #1359 (comment), we will need to modify the code to cross-support Faraday 1.x.x and 2.x.x when octokit pulls in the latest version of Faraday. Opening this issue now to track the work necessary when the times comes.

[klueless-io]

I'm not sure if this is related, but when I run this code

Octokit::Client.new(access_token: token)

I get this warning

WARNING: Faraday::Connection#authorization is deprecated; it will be removed in version 2.0.
While initializing your connection, use #request(:authorization, ...) instead

I'm aware of this Faraday Middleware Guide but I'm not sure how this relates to Octokit::Client

Is there a way of suppressing the warning with Octokit at the moment?

[dsandstrom]

@klueless-io It's what #1359 addresses. The fix is not published yet, but you could use the github version of the gem.

gem 'octokit', github: 'octokit/octokit.rb', tag: '4-stable'

Edit: I noticed a new version (4.22.0) was published today, so above not required now.

[indigok]

Cross referencing other issues showing that such support would be widely appreciated:

• Authentication changes with Octokit v4.22 causes failures with legacy Faraday versions #1392
• Authentication broken with Octokit 4.22.0 and GitHub Enterprise 3.1.2 #1391
• Looks like 4.22.0 is breaking CI builds that rely on 5.16.1 of danger gem #1389

[professor]

Thanks for doing this work.

Note that for octokit to be installed with Faraday 2.x.x, we'll need to bump sawyer to either 0.9.0 or 0.9.1

[nickfloyd]

Cross-referencing given that v4.23.0 introduces v2 support via #1411

[nickfloyd]

This is now supported from v4.23.0 and on. I'm closing this issue but if you feel that the latest releases have not solved this please feel free to repoen this and we'll have a look.