Fix contributors endpoint for empty repos #1025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #912
Closes #994
Me, @srinjoym and @BenEmdon finished up @Kadaaran 's work from #994, fixing the timeout bug in the contributors endpoint.
GitHub returns a 204 when asking for statistics on empty repos. Previously, Octokit would continue to retry until the retry timeout was reached.
This PR just returns
[]
when a 204 is returned.Also wrote a few tests showing we don't retry when a 204 is returned, and that octokit returns
[]
when GitHub returns a 204.cc @tarebyte @kytrinyx for review