App installation finders #1052
Merged
App installation finders #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what's going on with the Travis build for Ruby 2: looks like it's impacting another recent PR (#1050, https://travis-ci.org/octokit/octokit.rb/jobs/416504205). |
|
Ah, looks like Public Suffix (https://github.com/weppos/publicsuffix-ruby) dropped support for Rubies < 2.1 with version 3.0, referenced in this PR #948 |
tarebyte
requested changes
Aug 20, 2018
lib/octokit/client/apps.rb
Outdated
| # @return [Sawyer::Resource] Installation information | ||
| def find_organization_installation(organization, options = {}) | ||
| opts = ensure_api_media_type(:integrations, options) | ||
| get "orgs/#{organization}/installation", opts |
There was a problem hiding this comment.
Can we use the Organization.path helper here?
get "#{Organization.path(organization)}/installation", opts
lib/octokit/client/apps.rb
Outdated
| # @return [Sawyer::Resource] Installation information | ||
| def find_repository_installation(repo, options = {}) | ||
| opts = ensure_api_media_type(:integrations, options) | ||
| get "repos/#{repo}/installation", opts |
There was a problem hiding this comment.
Can we use the Repository.path helper here?
get "#{Repository.path(repo)}/installation", opts
lib/octokit/client/apps.rb
Outdated
| # @return [Sawyer::Resource] Installation information | ||
| def find_user_installation(user, options = {}) | ||
| opts = ensure_api_media_type(:integrations, options) | ||
| get "users/#{user}/installation", opts |
There was a problem hiding this comment.
Can we use the User.path helper here?
get "#{User.path(user)}/installation", opts
|
Sensible suggestions, updated. Thank @tarebyte! |
…t.rb into app-installation-finders
tarebyte
approved these changes
Aug 21, 2018
|
I think this is ready to merge, thanks @tarebyte! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the following installation finders from the Github Apps preview API to Octokit: