Remove the :name key from #add_team_repository request

[BenEmdon]

What

It appears the API began validating the presence of parameters on the request teams/:team_id/repos/:org/:repo_name. When a request contained the parameter key name it would be rejected by the API with a status of 422.

Using the method #add_team_repository would yield a 422 status with the message:

"name" is not a permitted key. // See: https://developer.github.com/v3/teams/#add-or-update-team-repository

This PR proposes a fix to drop the extra param :name which no longer serves a purpose.

API reference https://developer.github.com/v3/teams/#add-or-update-team-repository

---

Fixes #1051 closes #1053

[d12]

@kytrinyx Do you think you could take a peek at this when you get a moment?

[BenEmdon]

To check that this method is broken I made a PR with a failing test, then patched classroom with my octokit.rb fork.

See github-education-resources/classroom#1483

[kytrinyx]

This is my bad. I meant to deploy this validation as a scientist experiment to see what would fail without actually making things fail. I will deploy a fix momentarily.

[BenEmdon]

@kytrinyx no problem, thanks for the fix upstream!
Should this patch still merge if it is equivalent to the old way (but fitting within the ideals of upstream)?

[kytrinyx]

I think we should merge the patch. The API doesn't accept a :name parameter according to the docs:
https://developer.github.com/v3/teams/#add-or-update-team-repository

The codebase just ignores it currently, (well, it did until two days ago /facepalm). So while we should make the API backwards compatible, it would make sense to update the client to actually match the documented behavior.

[kytrinyx]

🍰