Use new app installation token endpoint #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tarebyte - looks like you're the right person to review this. Would it be possible to get a speedy release if you're happy with it? That September 4th deadline for removing the route is soon! |
|
Thanks for the PR. Just tried the gem and it failed to install the app. Didn't realized there's a new endpoint for the app installation. |
|
@tarebyte @kytrinyx I wanted to echo @greysteil's request for this to be released as soon as possible so there's time to integrate it before the breaking change in the API on September 4th – that date is coming up 😨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app installation token routes is being moved, as publicised in this changelog entry.
This PR updates the endpoint Octokit uses to the new one.