Add client methods for the Checks API #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
tarebyte
approved these changes
Jan 17, 2019
| @@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) | |||
| require 'octokit/version' | |||
|
|
|||
| Gem::Specification.new do |spec| | |||
| spec.add_development_dependency 'bundler', '~> 1.0' | |||
| spec.add_development_dependency 'bundler', '>= 1', '< 3' | |||
Closed
Closed
|
@tarebyte can we get a new release with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #1074 and #1075
👋 Hello! This pull request is functionally complete,
but still a work in progress due to documentation. I'd like to get your 👀 on the naming and implementationwhile I round out the docs. I tried to stick to existing conventions as much as possible, but please let me know if there are any changes you'd like to see. Thank you! 💛Update: The build was failing for unrelated reasons. The latest version of Bundler is 2.0.1 but the gemspec specified Bundler
~> 1.0. I've expanded that requirement to include Bundler 2.x. I've also taken the liberty of adding Ruby 2.6 to the build and to the list of supported Rubies. I'm happy to remove that if you prefer! 💚Update 2: Documentation is finished and this is ready for review! 💙
To-Do
coverage/index.htmlfor 💯% code coveragebundle exec rake doc:yardto test documentation coverage