Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to inherit from correct Faraday error #1154

Merged
merged 6 commits into from
Oct 17, 2019
Merged

Update to inherit from correct Faraday error #1154

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3e9054b
Update to inherit from correct Faraday error
Gasparila Sep 27, 2019
11c65a6
Add faraday requirement
Gasparila Sep 27, 2019
2422c9c
Merge branch 'master' into kevin/fix_faraday_inheritance
tarebyte Sep 27, 2019
d4d77dc
Relax dependency
Gasparila Sep 28, 2019
bf32723
Merge branch 'kevin/fix_faraday_inheritance' of github.com:flexport/o…
Gasparila Sep 28, 2019
33a4ef0
Merge branch 'master' into kevin/fix_faraday_inheritance
tarebyte Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/octokit/middleware/follow_redirects.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module Octokit
module Middleware

# Public: Exception thrown when the maximum amount of requests is exceeded.
class RedirectLimitReached < Faraday::Error::ClientError
class RedirectLimitReached < Faraday::ClientError
attr_reader :response

def initialize(response)
Expand Down
1 change: 1 addition & 0 deletions octokit.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ require 'octokit/version'
Gem::Specification.new do |spec|
spec.add_development_dependency 'bundler', '>= 1', '< 3'
spec.add_dependency 'sawyer', '>= 0.5.3', '~> 0.8.0'
spec.add_dependency 'faraday', '>= 0.9', '< 2.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will pick up v0.16.0, which is the affected version. I think we just want to change the constant.

Suggested change
spec.add_dependency 'faraday', '>= 0.9', '< 2.0'
spec.add_dependency 'faraday', '>= 0.9'

If we want a version constraint, we want it as permissive as possible.

spec.authors = ["Wynn Netherland", "Erik Michaels-Ober", "Clint Shryock"]
spec.description = %q{Simple wrapper for the GitHub API}
spec.email = ['wynn.netherland@gmail.com', 'sferik@gmail.com', 'clint@ctshryock.com']
Expand Down