-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow.yml & Gemfile #1196
Conversation
Actions' 'reporting' get mixed up when a workflow's jobs change. JFYI, doc's for master branch are at https://msp-greg.github.io/octokit/. Normally updated daily... |
Thanks for the PR @MSP-Greg, I don't think we want to support Ruby versions that are listed as unmaintained or EOL. That's out of scope for this gem. Can we set that back to 2.5 - ruby-head ? |
Change the gemspec also? Line 19 in 9f19351
|
We'll do that on the v5 release |
8330630
to
aaf5b77
Compare
Done. Are 4-stable and master split? If there will be more 4-stable releases, that branch (ideally) should have CI matching the gemspec version. This PR is against master right now. And, I did not add macOS testing, but normally for a straight ruby repo, if Ubuntu passes, macOS will also. |
1. CI on Ubuntu & Windows, Ruby 2.5 thru master 2. Cache bundler 3. Update Gemfile for stdlib -> bundled gems Notes 4. Windows is slower, will be helped when Actions adds MSYS2 5. Ubuntu 2.6 seems to have intermittent failures
aaf5b77
to
db9bcc6
Compare
To allow work in fork branches, I added '*':
|
Should I close this and open a new PR to 4-stable? Never tried changing the destination branch, can't see an option to do so... |
Closing in favor of PR #1206, which is the same thing but against 4-stable |
Notes