Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow.yml & Gemfile #1196

Closed
wants to merge 1 commit into from

Conversation

MSP-Greg
Copy link
Contributor

@MSP-Greg MSP-Greg commented Feb 14, 2020

  1. CI on Ubuntu & Windows, Ruby 2.5 thru master
  2. Cache bundler
  3. Update Gemfile for stdlib -> bundled gems

Notes

  1. Windows is slower, will be helped when Actions adds MSYS2
  2. CI has random failures. See PR client_spec.rb - fix random failures #1201

@MSP-Greg
Copy link
Contributor Author

Actions' 'reporting' get mixed up when a workflow's jobs change.

JFYI, doc's for master branch are at https://msp-greg.github.io/octokit/. Normally updated daily...

@tarebyte
Copy link
Member

Thanks for the PR @MSP-Greg, I don't think we want to support Ruby versions that are listed as unmaintained or EOL. That's out of scope for this gem.

Can we set that back to 2.5 - ruby-head ?

@MSP-Greg
Copy link
Contributor Author

Change the gemspec also?

spec.required_ruby_version = '>= 2.0.0'

@tarebyte
Copy link
Member

Change the gemspec also?

We'll do that on the v5 release

@MSP-Greg MSP-Greg force-pushed the try-ruby-setup-ruby branch from 8330630 to aaf5b77 Compare February 14, 2020 23:31
@MSP-Greg
Copy link
Contributor Author

Can we set that back to 2.5 - ruby-head ?

Done.

Are 4-stable and master split?

If there will be more 4-stable releases, that branch (ideally) should have CI matching the gemspec version. This PR is against master right now. And, I did not add macOS testing, but normally for a straight ruby repo, if Ubuntu passes, macOS will also.

1. CI on Ubuntu & Windows, Ruby 2.5 thru master
2. Cache bundler
3. Update Gemfile for stdlib -> bundled gems

Notes

4. Windows is slower, will be helped when Actions adds MSYS2
5. Ubuntu 2.6 seems to have intermittent failures
@MSP-Greg MSP-Greg force-pushed the try-ruby-setup-ruby branch from aaf5b77 to db9bcc6 Compare February 25, 2020 05:31
@MSP-Greg
Copy link
Contributor Author

To allow work in fork branches, I added '*':

on:
   push:
     branches:
     - master
     - 4-stable
     - '*'

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Mar 2, 2020

Should I close this and open a new PR to 4-stable? Never tried changing the destination branch, can't see an option to do so...

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Mar 4, 2020

Closing in favor of PR #1206, which is the same thing but against 4-stable

@MSP-Greg MSP-Greg closed this Mar 4, 2020
@MSP-Greg MSP-Greg deleted the try-ruby-setup-ruby branch April 14, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants