Clear last_response on errors #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an error occurs, the last_response does not get updated so it's possible to start inspecting the last last response. This change makes it so that if an error is raised, clear the last_response cache to prevent leaky reads
tarebyte
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error occurs, the last_response does not get updated so
last_responsehere actually starts showing the last successful response rather than the raw last response.On Shopify/shipit-engine, we had a problem due to this behaviour in sidekiq where API requests are failing and we end up processing the
last_responsefrom the previous job on the thread.This change makes it so that if an error is raised, clear the last_response cache to prevent leaky reads, while reraising the error so that functionality stays mostly the same.
I think this better captures the behavior I would expect form a
last_responsecache, at least to prevent "stale" reads.Thanks!