Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checks pagination #1415

Merged
merged 8 commits into from
May 25, 2022
Merged

Fix checks pagination #1415

merged 8 commits into from
May 25, 2022

Conversation

matiasalbarello
Copy link
Contributor

Based on this PR: #1321

  • Fixed merging conflict
  • Added missing tests
  • Added missing pagination
  • Fixed total_count calculation when paginating results

@matiasalbarello
Copy link
Contributor Author

@a2ikm I've cherry-picked your commit here since I couldn't push commits on your PR.

@matiasalbarello matiasalbarello mentioned this pull request May 3, 2022
Merged
@matiasalbarello matiasalbarello changed the title Add tests on paginate checks Fix checks pagination May 4, 2022
@matiasalbarello matiasalbarello mentioned this pull request May 6, 2022
Closed
@a2ikm
Copy link
Contributor

a2ikm commented May 18, 2022

@matiasalbarello
I really appreciate for your rebasing and adding tests! Thanks a lot!!

@nickfloyd nickfloyd added the bug label May 24, 2022
@nickfloyd nickfloyd merged commit cf9b383 into octokit:4-stable May 25, 2022
@matiasalbarello matiasalbarello deleted the add-tests-on-paginate-checks branch May 26, 2022 06:40
@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed bug labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattpage mattpage mattpage approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matiasalbarello @a2ikm @mattpage @nickfloyd