Adds ability to update pull request branch #1472
Conversation
lib/octokit/client/pull_requests.rb
Outdated
| # @param options [Hash] Optional parameters (e.g. expected_head_sha) | ||
| # @return [Sawyer::Resource] Info regarding the update if successful | ||
| def update_pull_request_branch(repo, number, options = {}) | ||
| put "#{Repository.path repo}/pulls/#{number}/update-branch", options |
There was a problem hiding this comment.
What do you thinking of using #boolean_from_response here? Looking at the API, it appears that the response is not super useful - you just want to know if it worked or not.
| put "#{Repository.path repo}/pulls/#{number}/update-branch", options | |
| boolean_from_response(:put, "#{Repository.path repo}/pulls/#{number}/update-branch", options) |
| @@ -136,6 +136,15 @@ | |||
| end | |||
| end # new @pull methods | |||
|
|
|||
| # stub this so we don't have to set up new fixture data | |||
| describe '.update_pull_request_branch' do | |||
There was a problem hiding this comment.
We should test the return value of #update_pull_request_branch in here.
|
Thanks for the quick review - I can address that feedback shortly. What are your thoughts on having the API called stubbed vs. having a cassette for it? |
I'm okay for it to be stubbed. Could we stub it with an actual response for better test. overage? |
|
Addressed your feedback. I've changed |
This comment was marked as spam.
This comment was marked as spam.
Returns true if updating the pull request branch was successful. Also improves test coverage.
Resolves #1471
As per https://docs.github.com/en/rest/pulls/pulls#update-a-pull-request-branch. I couldn't get the specs to work with VCR despite creating a test repo and setting all relevant ENV vars. I decided to stub the request instead.