Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add using GitHub app authentication in README #1512

Conversation

Tatsumi0000
Copy link
Contributor

@Tatsumi0000 Tatsumi0000 commented Dec 5, 2022

Behavior

Before the change?

  • There was no explanation in the README for authentication using GitHub App.

After the change?

  • Add using GitHub app authentication for README.

Other information

Reference information.


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@Tatsumi0000 Tatsumi0000 marked this pull request as ready for review December 5, 2022 14:38
README.md Outdated Show resolved Hide resolved
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! Builds are failing due to an unrelated issue I need to sort out. When I do, this PR will be merged!

@kfcampbell kfcampbell added the Type: Documentation Improvements or additions to documentation label Dec 6, 2022
@Tatsumi0000
Copy link
Contributor Author

Thank you for contributing! Builds are failing due to an unrelated issue I need to sort out. When I do, this PR will be merged!

Thanks for review it!
I understand the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants