Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jruby-specific platform #1520

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

kfcampbell
Copy link
Member

@kfcampbell kfcampbell commented Dec 16, 2022

Resolves #1519. Thank you @composerinteralia for the tip!

Previously, our Ruby head build was failing looking for a specific version of json in a list of empty platforms. Speculative: perhaps an underlying change in Ruby or bundler caused errors with the platforms: [:jruby] specification in our Gemfile.


Behavior

Before the change?

  • Ruby head builds are broken due to a gem resolution error.

After the change?

  • Ruby head builds are successful.

Other information

  • This issue is obnoxious! We want to fix the build so we can ship several PRs we have on deck.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@kfcampbell kfcampbell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Dec 16, 2022
@kfcampbell kfcampbell requested a review from nickfloyd December 16, 2022 18:55
@kfcampbell kfcampbell marked this pull request as ready for review December 16, 2022 18:55
@composerinteralia
Copy link

rubygems/rubygems#5960 is what changed the behavior

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@kfcampbell kfcampbell merged commit 6f418c6 into octokit:main Dec 16, 2022
@kfcampbell kfcampbell deleted the attempt-build-fix branch December 16, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAINT]: bundle install fails on Ruby head (3.2.0-dev)
3 participants