Allow using the response_headers or headers when getting Rate Limit Info #1533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1400
Behavior
Before the change?
Octokit::TooManyRequests#context.rate_limit
methods return nilAfter the change?
Octokit::TooManyRequests#context.rate_limit
methods return the correct valuesOther information
headers
field overresponse_headers
, it's not clear to me whenheaders
was valid (I'm not sure if it was an older version of faraday or something), I looked through the code and I think it's because theon_complete
usesresponse_env
(might be here instead ofresponse
(Faraday::Response
hasheaders
delegating toenv.response_headers
Note: I can't see where to add in bug fix information in this repo?
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Type: Bug