-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHES Manage API client #1688
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
b6e4fc8
to
ed2a96c
Compare
ed2a96c
to
271cc14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @manue1 thanks for the changes here and apologies for the delay on getting a review out to you. ❤️ These changes look good overall, there is one change to the console message produced from the Faraday check - have a look at what I am proposing and let me know what you think.
Co-authored-by: Nick Floyd <139819+nickfloyd@users.noreply.github.com>
Hey nick! Please do not merge this PR yet, just been notified I need to make a quick modification, but I will not be able to do it until Friday :) |
@nickfloyd Ready to go 👍🏻 |
@alejndr0 Thx for the updates... I am looking at this now and will get it reviewed and hopefully released this morning. |
Adds
octokit.rb
support for GHES Manage API endpoints.Given that the GHES Manage API going forward will be the only supported API for managing GHES instances we have added support for endpoints that up until now were part of the Management Console API (see its deprecation notice here).
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!