Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHES Manage API client #1688

Merged
merged 19 commits into from
Jun 10, 2024
Merged

Conversation

manue1
Copy link
Contributor

@manue1 manue1 commented May 16, 2024

Adds octokit.rb support for GHES Manage API endpoints.

Given that the GHES Manage API going forward will be the only supported API for managing GHES instances we have added support for endpoints that up until now were part of the Management Console API (see its deprecation notice here).


Before the change?

  • No GHES Manage API support was in place

After the change?

  • All endpoints that were previously covered by the Management Console API client are now also included in the GHES Manage API client

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@manue1 manue1 force-pushed the manue1/manage-api-support branch from b6e4fc8 to ed2a96c Compare May 22, 2024 21:17
@manue1 manue1 force-pushed the manue1/manage-api-support branch from ed2a96c to 271cc14 Compare May 22, 2024 21:21
@manue1 manue1 marked this pull request as ready for review June 3, 2024 13:47
@nickfloyd nickfloyd added the Type: Feature New feature or request label Jun 4, 2024
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @manue1 thanks for the changes here and apologies for the delay on getting a review out to you. ❤️ These changes look good overall, there is one change to the console message produced from the Faraday check - have a look at what I am proposing and let me know what you think.

lib/octokit/default.rb Outdated Show resolved Hide resolved
Co-authored-by: Nick Floyd <139819+nickfloyd@users.noreply.github.com>
@alejndr0
Copy link
Contributor

alejndr0 commented Jun 5, 2024

Hey @manue1 thanks for the changes here and apologies for the delay on getting a review out to you. ❤️ These changes look good overall, there is one change to the console message produced from the Faraday check - have a look at what I am proposing and let me know what you think.

Hey nick! Please do not merge this PR yet, just been notified I need to make a quick modification, but I will not be able to do it until Friday :)

@nickfloyd nickfloyd self-requested a review June 5, 2024 16:01
@alejndr0
Copy link
Contributor

alejndr0 commented Jun 7, 2024

@nickfloyd Ready to go 👍🏻

@nickfloyd
Copy link
Contributor

@alejndr0 Thx for the updates... I am looking at this now and will get it reviewed and hopefully released this morning.

@nickfloyd nickfloyd merged commit cff7c55 into octokit:main Jun 10, 2024
12 checks passed
@manue1 manue1 deleted the manue1/manage-api-support branch July 1, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants