-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings #434
Fix warnings #434
Conversation
I tried this out and got a warning from Bundler: $ bundle
Fetching gem metadata from https://rubygems.org/.........
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
You have requested:
rspec >= 2.14
The bundle currently has rspec locked at 2.13.0.
Try running `bundle update spec` Is an updated |
Thanks. Would the cane gem or some other tool catch these in the future? @zenspider Are these the only sources of your ❤️🔥? We have a few instances of
@sferik Done. I've just been adding people back as they ask. ⚡ |
@catsby The @pengwynn I‘m pretty sure @zenspider was concerned with warnings being thrown by Ruby, not deprecation warnings coming from Octokit.rb. This patch fixes all of them. PS: Thanks for adding me back to the project. I’m going to merge this now. |
Inspired by @zenspider.
PS: Can I please get push access restored? I think it went away when the repository was moved to the octokit organization. Or is membership for Githubbers only?