Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #434

Merged
merged 11 commits into from
Feb 26, 2014
Merged

Fix warnings #434

merged 11 commits into from
Feb 26, 2014

Conversation

sferik
Copy link
Member

@sferik sferik commented Feb 26, 2014

Inspired by @zenspider.

PS: Can I please get push access restored? I think it went away when the repository was moved to the octokit organization. Or is membership for Githubbers only?

@catsby
Copy link
Contributor

catsby commented Feb 26, 2014

I tried this out and got a warning from Bundler:

$ bundle
Fetching gem metadata from https://rubygems.org/.........
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
You have requested:
  rspec >= 2.14

The bundle currently has rspec locked at 2.13.0.
Try running `bundle update spec`

Is an updated Gemfile.lock needed for existing installs? (Where Travis CI would be new installs and not get this warning)

@pengwynn
Copy link
Collaborator

Thanks. Would the cane gem or some other tool catch these in the future?

@zenspider Are these the only sources of your ❤️🔥? We have a few instances of warn() for deprecations and preview features that aren't so nice for building CLI tools. Taking inspiration from minitest, we could check something like ENV["OCTOKITIGOTTHISDONTSHOWMEWARNINGSYO"] and mute those.

Can I please get push access restored?

@sferik Done. I've just been adding people back as they ask. ⚡

@sferik
Copy link
Member Author

sferik commented Feb 26, 2014

@catsby The Gemfile.lock is ignored, so you have to run bundle update after you pull, not bundle install.

@pengwynn I‘m pretty sure @zenspider was concerned with warnings being thrown by Ruby, not deprecation warnings coming from Octokit.rb. This patch fixes all of them.

PS: Thanks for adding me back to the project. I’m going to merge this now.

sferik added a commit that referenced this pull request Feb 26, 2014
@sferik sferik merged commit 17d27da into octokit:master Feb 26, 2014
@arthurnn arthurnn mentioned this pull request Feb 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants