-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new methods from the most recent org memberships API enhancements #841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let one comment about an alias, but overall looks good to me @LizzHale!
def organization_invitations(org, options = {}) | ||
options = ensure_api_media_type(:org_memberships, options) | ||
get "#{Organization.path org}/invitations", options | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we support aliases for the other organization methods, what do you think about supporting:
alias :org_invitations :organization_invitations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed -- added in 4dd9c28
Thanks for doing this @LizzHale! |
While pushing the code to different user git hub repository, getting below error |
This PR adds the new methods for the most recent org memberships API enhancements.
In addition, I also updated the documentation to include new parameters for existing methods.
maintainer
parameter to the create team methodaffiliation
parameter to the collaborators methoddefault_repository_permission
andmembers_can_create_repositories
to the update organization methodI ran into one snag while creating the permission level endpoint method test. The tests timed out when creating a new cassette in the repositories spec when the before block creates a repository with
test_github_repository
because of a loop here. I ended up putting my test under this context which doesn't utilize thetest_github_repository
name but I think the test makes more sense with the tests in the other context./cc @pengwynn @joeyw for review
/cc @NadaAldahleh @hktouw for awareness
Closes #711