Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application requests for non dotcom hosts #851

Merged
merged 3 commits into from
Jan 5, 2017

Conversation

pengwynn
Copy link
Collaborator

@pengwynn pengwynn commented Jan 5, 2017

Fixes #831, this change switches to a relative path so that URLs are built correctly on Enterprise (and lab) hosts.

/cc @tarebyte @gordondiggs

@pengwynn
Copy link
Collaborator Author

pengwynn commented Jan 5, 2017

This checks out locally. Looks like we need to troubleshoot CI on Travis, @tarebyte.

@tarebyte
Copy link
Member

tarebyte commented Jan 5, 2017

Nice @pengwynn! I totally thought that we were going to have to fix this at a higher level.

I'll take a look at the CI errors.

@coveralls
Copy link

coveralls commented Jan 5, 2017

Coverage Status

Coverage remained the same at 99.33% when pulling 26ef1be on fix-application-requests-for-ent into 3887fd5 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.33% when pulling 26ef1be on fix-application-requests-for-ent into 3887fd5 on master.

@tarebyte
Copy link
Member

tarebyte commented Jan 5, 2017

:shipit:

@pengwynn pengwynn merged commit adab5f6 into master Jan 5, 2017
@pengwynn pengwynn deleted the fix-application-requests-for-ent branch January 5, 2017 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants