Add marketplace listings API endpoints #929
Conversation
1 similar comment
|
@tarebyte are you the right person to review? |
|
@sbarnekow - FYI, I wrote this while I was getting a feel for the API. Should make integrating with marketplace even easier for anyone else written in Ruby. |
| # Methods for the Marketplace Listing API | ||
| # | ||
| # @see https://developer.github.com/v3/apps/marketplace/ | ||
| module MarketplaceListings |
There was a problem hiding this comment.
Let's go ahead and rename this to Marketplace
| def plan_for_account(account_id, options = {}) | ||
| opts = ensure_api_media_type(:marketplace, options) | ||
| get "/marketplace_listing/accounts/#{account_id}", opts | ||
| rescue Octokit::NotFound |
There was a problem hiding this comment.
Since this isn't consistent with the rest of Octokit, let's go ahead and remove this rescue so the error bubbles up.
| @@ -15,6 +15,7 @@ module Preview | |||
| :projects => 'application/vnd.github.inertia-preview+json'.freeze, | |||
| :traffic => 'application/vnd.github.spiderman-preview'.freeze, | |||
| :integrations => 'application/vnd.github.machine-man-preview+json'.freeze, | |||
| :marketplace => 'application/vnd.github.valkyrie-preview+json'.freeze, | |||
|
|
||
| private | ||
|
|
||
| def new_jwt_token |
There was a problem hiding this comment.
Since this is now used in two different test files, let's move this into the spec/helper.rb so we don't repeat logic.
1 similar comment
|
@tarebyte - updated and 💚 |
| end | ||
|
|
||
| # List all GitHub accounts on a specific plan | ||
| # |
There was a problem hiding this comment.
Would you mind adding the plan parameter here?
lib/octokit/client/marketplace.rb
Outdated
| end | ||
|
|
||
| # Get the plan associated with a given GitHub account | ||
| # |
There was a problem hiding this comment.
Would you mind adding the account_id parameter here?
1 similar comment
1 similar comment
1 similar comment
|
🍰 |
That. 🎁